Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15643 test: Enable dfuse register cleanup model #14215

Merged
merged 27 commits into from
May 7, 2024
Merged

DAOS-15643 test: Enable dfuse register cleanup model #14215

merged 27 commits into from
May 7, 2024

Conversation

phender
Copy link
Contributor

@phender phender commented Apr 22, 2024

This replaces the DfuseTestBase with the use of the get_dfuse and start_dfuse methods from dfuse_utils.

Skip-unit-tests: true
Skip-fault-injection-test: true
Allow-unstable-test: true
Test-tag: DaosCoreTestDfuse DbenchTest DFuseFdTest DfuseBashCmd DfuseContainerCheck DfuseContainerCheck DaosBuild DfuseFind DfuseEnospace DfuseMUMount DfuseMUPerms MacsioTest Ecodtruncate EcodFioRebuild PosixSimul RootContainerTest test_ior_small DfuseCachingCheck POSIXStatTest IoConsistency MultiEnginesPerSocketTest BasicCheckout

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@phender
DAOS-15643 test: Enable dfuse register cleanup model
8d680c5 
This replaces the DfuseTestBase with the use of the get_dfuse and
start_dfuse methods from dfuse_utils.

Skip-unit-tests: true
Skip-fault-injection-test: true
Allow-unstable-test: true
Test-tag: DaosCoreTestDfuse DbenchTest DFuseFdTest DfuseBashCmd DfuseContainerCheck DfuseContainerCheck DaosBuild DfuseFind DfuseEnospace DfuseMUMount DfuseMUPerms MacsioTest Ecodtruncate EcodFioRebuild PosixSimul RootContainerTest test_ior_small DfuseCachingCheck POSIXStatTest IoConsistency MultiEnginesPerSocketTest BasicCheckout

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 22, 2024 •
edited
Loading

Ticket title is 'Enable dfuse register cleanup model'
Status is 'In Progress'
Labels: 'test_2.6'
https://daosio.atlassian.net/browse/DAOS-15643

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14215/1/execution/node/331/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14215/1/execution/node/365/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14215/1/execution/node/368/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14215/1/execution/node/350/log

ashleypittman
ashleypittman reviewed Apr 23, 2024
View reviewed changes
src/tests/ftest/dfuse/bash_fd.py Outdated

with open(os.path.join(fuse_root_dir, "bash_fd_inner.sh"), "w") as fd:
self.log_step('Setting up the \'bash_fd_inner.sh\' script')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI - you can use either " or ' for strings, but if you want to include one of them in the string then use the other to quote the string and you won't need to escape it.

Suggested change
self.log_step('Setting up the \'bash_fd_inner.sh\' script')
self.log_step("Setting up the 'bash_fd_inner.sh' script")

@phender
Merge branch 'master' into pahender/DAOS-15643
57a430a 
Skip-unit-tests: true
Skip-fault-injection-test: true
Allow-unstable-test: true
Test-tag: DaosCoreTestDfuse DbenchTest DFuseFdTest DfuseBashCmd DfuseContainerCheck DfuseContainerCheck DaosBuild DfuseFind DfuseEnospace DfuseMUMount DfuseMUPerms MacsioTest Ecodtruncate EcodFioRebuild PosixSimul RootContainerTest test_ior_small DfuseCachingCheck POSIXStatTest IoConsistency MultiEnginesPerSocketTest BasicCheckout

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@phender phender marked this pull request as ready for review April 24, 2024 23:54
@phender phender requested review from a team as code owners April 24, 2024 23:54
@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14215/3/execution/node/349/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14215/3/execution/node/362/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14215/3/execution/node/279/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14215/3/execution/node/346/log

@daosbuild1
Copy link
Collaborator

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14215/3/display/redirect

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14215/3/display/redirect

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14215/4/execution/node/366/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14215/4/execution/node/381/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14215/4/execution/node/326/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14215/4/execution/node/319/log

@daosbuild1
Copy link
Collaborator

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14215/4/display/redirect

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14215/4/display/redirect

@daosbuild1
Copy link
Collaborator

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14215/5/display/redirect

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14215/5/display/redirect

@daosbuild1
Copy link
Collaborator

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14215/6/display/redirect

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14215/6/display/redirect

@phender
Merge branch 'master' into pahender/DAOS-15643
e84c963 
Skip-unit-tests: true
Skip-fault-injection-test: true
Allow-unstable-test: true
Test-tag: DaosCoreTestDfuse DbenchTest DFuseFdTest DfuseBashCmd DfuseContainerCheck DfuseContainerCheck DaosBuild DfuseFind DfuseEnospace DfuseMUMount DfuseMUPerms MacsioTest Ecodtruncate EcodFioRebuild PosixSimul RootContainerTest test_ior_small DfuseCachingCheck POSIXStatTest IoConsistency MultiEnginesPerSocketTest BasicCheckout

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14215/7/execution/node/376/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14215/7/execution/node/350/log

daltonbohning
daltonbohning previously approved these changes May 2, 2024
View reviewed changes
mjean308
mjean308 previously approved these changes May 3, 2024
View reviewed changes
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14215/30/execution/node/992/log

@phender
Merge branch 'master' into pahender/DAOS-15643
beabd59
@phender
Fix test failures.
5806cc8 
Skip-unit-tests: true
Skip-fault-injection-test: true
Allow-unstable-test: true
Test-tag: pr dfuse AggregationChecksum AggregationPunching BasicCheckout BasicCheckoutDm CPUUsage CheckCsumMetricsMdtest DFuseBashdcacheTest DFuseFdTest DaosAggregationBasic DaosAggregationIOSmall DaosAggregationThrottling DaosBuild DaosCoreTestDfuse DaosVol DaosVolBigIO DbenchTest DfuseBashCmd DfuseCachingCheck DfuseContainerCheck DfuseEnospace DfuseMUMount DfuseMUPerms DfuseSpaceCheck DmgPoolQueryTest DmvrNegativeTest DmvrPosixMetaEntry DmvrPosixSubsets DmvrPosixSymlinks DmvrPosixTypesTest DmvrSerialLargePosix EcodCellSize EcodCellSizeProperty EcodFaultInjection EcodFioRebuild EcodIor EcodMdtest EcodSpaceUsage Ecodtruncate FioPil4dfsSmall FioSmall IoAggregation IoConsistency IoSysAdmin IorCrash IorHardBasic IorInterceptMessages IorInterceptMessagesPil4dfs IorPerRank IorSmall LargeFileCount ListVerboseTest MacsioTest MdtestSmall MultiEnginesPerSocketTest MultipleContainerDelete OSAOfflineDrain OSAOfflineExtend OSAOfflineParallelTest OSAOfflineReintegration OSAOnlineDrain OSAOnlineExtend POSIXStatTest ParallelIo Pil4dfsDcache Pil4dfsFio PoolMembershipTest PoolTargetQueryTest PosixSimul RbldContainerCreate RbldWidelyStriped RbldWithIOR RebuildMdtest ReplayTests RootContainerTest SegCount SmallFileCount SparseFile TelemetryPoolMetrics TelemetryPoolSpaceMetrics TestScrubberEvictWithAggregation TestWithTelemetryIOBasic TestWithTelemetryIOLatency performance,-manual test_dfuse_pre_read DFusePreReadTest

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@phender phender dismissed stale reviews from mjean308 and daltonbohning via 5806cc8 May 3, 2024 18:33
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14215/32/execution/node/1038/log

@phender
Copy link
Contributor Author

phender commented May 6, 2024 •
edited
Loading

3 failures in https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14215/32/testReport/

  • 1-./daos_vol/bigio.py:DaosVolBigIO.test_daos_vol_bigio
  • 1-./deployment/io_sys_admin.py:IoSysAdmin.test_io_sys_admin
    • H5_daos_file_create(): file creation failed in task "DAOS container query completion callback": invalid value received (H5_DAOS_BAD_VALUE)
    • This fails because the IorTestBase.run_ior_with_pool() method no longer stops dfuse by default, which when called again ends up starting dfuse again (if needed).
  • 3-./recovery/pool_membership.py:PoolMembershipTest.test_dangling_rank_entry
    • write_host_file: ValueError: hosts parameter must be provided.

@phender
Merge branch 'master' into pahender/DAOS-15643
239aa88
@phender
Reinstating the run_ior_with_pool(stop_dfuse=True) argument.
201ac08 
Skip-unit-tests: true
Skip-fault-injection-test: true
Allow-unstable-test: true
Test-tag: pr dfuse AggregationChecksum AggregationPunching BasicCheckout BasicCheckoutDm CPUUsage CheckCsumMetricsMdtest DFuseBashdcacheTest DFuseFdTest DaosAggregationBasic DaosAggregationIOSmall DaosAggregationThrottling DaosBuild DaosCoreTestDfuse DaosVol DaosVolBigIO DbenchTest DfuseBashCmd DfuseCachingCheck DfuseContainerCheck DfuseEnospace DfuseMUMount DfuseMUPerms DfuseSpaceCheck DmgPoolQueryTest DmvrNegativeTest DmvrPosixMetaEntry DmvrPosixSubsets DmvrPosixSymlinks DmvrPosixTypesTest DmvrSerialLargePosix EcodCellSize EcodCellSizeProperty EcodFaultInjection EcodFioRebuild EcodIor EcodMdtest EcodSpaceUsage Ecodtruncate FioPil4dfsSmall FioSmall IoAggregation IoConsistency IoSysAdmin IorCrash IorHardBasic IorInterceptMessages IorInterceptMessagesPil4dfs IorPerRank IorSmall LargeFileCount ListVerboseTest MacsioTest MdtestSmall MultiEnginesPerSocketTest MultipleContainerDelete OSAOfflineDrain OSAOfflineExtend OSAOfflineParallelTest OSAOfflineReintegration OSAOnlineDrain OSAOnlineExtend POSIXStatTest ParallelIo Pil4dfsDcache Pil4dfsFio PoolMembershipTest PoolTargetQueryTest PosixSimul RbldContainerCreate RbldWidelyStriped RbldWithIOR RebuildMdtest ReplayTests RootContainerTest SegCount SmallFileCount SparseFile TelemetryPoolMetrics TelemetryPoolSpaceMetrics TestScrubberEvictWithAggregation TestWithTelemetryIOBasic TestWithTelemetryIOLatency performance,-manual test_dfuse_pre_read DFusePreReadTest

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@phender
Remove uneccessary changes.
edf2078 
Skip-unit-tests: true
Skip-fault-injection-test: true
Allow-unstable-test: true
Test-tag: pr dfuse AggregationChecksum AggregationPunching BasicCheckout BasicCheckoutDm CPUUsage CheckCsumMetricsMdtest DFuseBashdcacheTest DFuseFdTest DaosAggregationBasic DaosAggregationIOSmall DaosAggregationThrottling DaosBuild DaosCoreTestDfuse DaosVol DaosVolBigIO DbenchTest DfuseBashCmd DfuseCachingCheck DfuseContainerCheck DfuseEnospace DfuseMUMount DfuseMUPerms DfuseSpaceCheck DmgPoolQueryTest DmvrNegativeTest DmvrPosixMetaEntry DmvrPosixSubsets DmvrPosixSymlinks DmvrPosixTypesTest DmvrSerialLargePosix EcodCellSize EcodCellSizeProperty EcodFaultInjection EcodFioRebuild EcodIor EcodMdtest EcodSpaceUsage Ecodtruncate FioPil4dfsSmall FioSmall IoAggregation IoConsistency IoSysAdmin IorCrash IorHardBasic IorInterceptMessages IorInterceptMessagesPil4dfs IorPerRank IorSmall LargeFileCount ListVerboseTest MacsioTest MdtestSmall MultiEnginesPerSocketTest MultipleContainerDelete OSAOfflineDrain OSAOfflineExtend OSAOfflineParallelTest OSAOfflineReintegration OSAOnlineDrain OSAOnlineExtend POSIXStatTest ParallelIo Pil4dfsDcache Pil4dfsFio PoolMembershipTest PoolTargetQueryTest PosixSimul RbldContainerCreate RbldWidelyStriped RbldWithIOR RebuildMdtest ReplayTests RootContainerTest SegCount SmallFileCount SparseFile TelemetryPoolMetrics TelemetryPoolSpaceMetrics TestScrubberEvictWithAggregation TestWithTelemetryIOBasic TestWithTelemetryIOLatency performance,-manual test_dfuse_pre_read DFusePreReadTest

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@phender
Cleanup changes.
d5dfc6d 
Skip-unit-tests: true
Skip-fault-injection-test: true
Allow-unstable-test: true
Test-tag: pr dfuse AggregationChecksum AggregationPunching BasicCheckout BasicCheckoutDm CPUUsage CheckCsumMetricsMdtest DFuseBashdcacheTest DFuseFdTest DaosAggregationBasic DaosAggregationIOSmall DaosAggregationThrottling DaosBuild DaosCoreTestDfuse DaosVol DaosVolBigIO DbenchTest DfuseBashCmd DfuseCachingCheck DfuseContainerCheck DfuseEnospace DfuseMUMount DfuseMUPerms DfuseSpaceCheck DmgPoolQueryTest DmvrNegativeTest DmvrPosixMetaEntry DmvrPosixSubsets DmvrPosixSymlinks DmvrPosixTypesTest DmvrSerialLargePosix EcodCellSize EcodCellSizeProperty EcodFaultInjection EcodFioRebuild EcodIor EcodMdtest EcodSpaceUsage Ecodtruncate FioPil4dfsSmall FioSmall IoAggregation IoConsistency IoSysAdmin IorCrash IorHardBasic IorInterceptMessages IorInterceptMessagesPil4dfs IorPerRank IorSmall LargeFileCount ListVerboseTest MacsioTest MdtestSmall MultiEnginesPerSocketTest MultipleContainerDelete OSAOfflineDrain OSAOfflineExtend OSAOfflineParallelTest OSAOfflineReintegration OSAOnlineDrain OSAOnlineExtend POSIXStatTest ParallelIo Pil4dfsDcache Pil4dfsFio PoolMembershipTest PoolTargetQueryTest PosixSimul RbldContainerCreate RbldWidelyStriped RbldWithIOR RebuildMdtest ReplayTests RootContainerTest SegCount SmallFileCount SparseFile TelemetryPoolMetrics TelemetryPoolSpaceMetrics TestScrubberEvictWithAggregation TestWithTelemetryIOBasic TestWithTelemetryIOLatency performance,-manual test_dfuse_pre_read DFusePreReadTest

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14215/34/display/redirect

@phender
Fix run_ior_with_pool dfuse stop.
fa1bd6f 
Skip-unit-tests: true
Skip-fault-injection-test: true
Allow-unstable-test: true
Test-tag: pr dfuse AggregationChecksum AggregationPunching BasicCheckout BasicCheckoutDm CPUUsage CheckCsumMetricsMdtest DFuseBashdcacheTest DFuseFdTest DaosAggregationBasic DaosAggregationIOSmall DaosAggregationThrottling DaosBuild DaosCoreTestDfuse DaosVol DaosVolBigIO DbenchTest DfuseBashCmd DfuseCachingCheck DfuseContainerCheck DfuseEnospace DfuseMUMount DfuseMUPerms DfuseSpaceCheck DmgPoolQueryTest DmvrNegativeTest DmvrPosixMetaEntry DmvrPosixSubsets DmvrPosixSymlinks DmvrPosixTypesTest DmvrSerialLargePosix EcodCellSize EcodCellSizeProperty EcodFaultInjection EcodFioRebuild EcodIor EcodMdtest EcodSpaceUsage Ecodtruncate FioPil4dfsSmall FioSmall IoAggregation IoConsistency IoSysAdmin IorCrash IorHardBasic IorInterceptMessages IorInterceptMessagesPil4dfs IorPerRank IorSmall LargeFileCount ListVerboseTest MacsioTest MdtestSmall MultiEnginesPerSocketTest MultipleContainerDelete OSAOfflineDrain OSAOfflineExtend OSAOfflineParallelTest OSAOfflineReintegration OSAOnlineDrain OSAOnlineExtend POSIXStatTest ParallelIo Pil4dfsDcache Pil4dfsFio PoolMembershipTest PoolTargetQueryTest PosixSimul RbldContainerCreate RbldWidelyStriped RbldWithIOR RebuildMdtest ReplayTests RootContainerTest SegCount SmallFileCount SparseFile TelemetryPoolMetrics TelemetryPoolSpaceMetrics TestScrubberEvictWithAggregation TestWithTelemetryIOBasic TestWithTelemetryIOLatency performance,-manual test_dfuse_pre_read DFusePreReadTest

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@brianjmurrell brianjmurrell removed their request for review May 6, 2024 15:14
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14215/39/testReport/

@phender
Copy link
Contributor Author

phender commented May 7, 2024

Test results from https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14215/39/testReport/:

@phender phender added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label May 7, 2024
@phender phender requested a review from a team May 7, 2024 01:56
@phender phender merged commit e063b19 into master May 7, 2024
43 of 45 checks passed
@phender phender deleted the pahender/DAOS-15643 branch May 7, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianjmurrell brianjmurrell brianjmurrell left review comments

@mjean308 mjean308 mjean308 approved these changes

@daltonbohning daltonbohning daltonbohning approved these changes

@ashleypittman ashleypittman Awaiting requested review from ashleypittman

Assignees
No one assigned
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@phender @daosbuild1 @sylviachanoiyee @ashleypittman @brianjmurrell @daltonbohning @mjean308